<i18n dev> Review request : 7180362: RFE: Implement date cutover functionality for currency.properties file

[Naoto Sato]

Looks good to me.

Naoto

On 9/5/12 1:10 PM, Seán Coffey wrote:
> Latest webrev is available here :
> http://cr.openjdk.java.net/~coffeys/webrev.7180362.3.jdk8/
> <http://cr.openjdk.java.net/%7Ecoffeys/webrev.7180362.3.jdk8/>
>
> I've changed code so that ISO 8601 format is now expected.
>
> regards,
> Sean.
>
> On 30/08/2012 17:17, Seán Coffey wrote:
>> Stephen,
>>
>> just see your mail now (damn filters)
>>
>> Yes - this makes sense. I'll make the modification and run some more
>> tests to ensure all is ok.
>> Updated webrev to follow. I'll also follow up with getting new change
>> approved with the
>> compatibility/conformance team.
>>
>> regards,
>> Sean.
>>
>> On 29/08/2012 22:00, Stephen Colebourne wrote:
>>> I object to the implementation of this change, specifically the date
>>> format -
>>> "The format of date must be {@code 'yyyy-MM-dd-HH-mm-ss'}"
>>>
>>> There seems to be no reason not to use the standard ISO-8601 format
>>> here - yyyy-MM-dd'T'HH:mm:ss
>>>
>>> Stephen
>>> co-spec lead JSR-310
>>>
>>>
>>> On 28 August 2012 14:48, Seán Coffey <sean.coffey at oracle.com> wrote:
>>>> 7180362 deals with an enhancement to allow the JRE specify cutover
>>>> dates
>>>> when currency.properties file is provided. I've added the required
>>>> syntax to
>>>> the new javadoc comments in Currency class.
>>>>
>>>> bug report :http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7180362
>>>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.7180362.1.jdk8/
>>>> <http://cr.openjdk.java.net/%7Ecoffeys/webrev.7180362.1.jdk8/>
>>>>
>>>> I hope to port an almost identical change to 7u shortly. (minus API
>>>> javadoc
>>>> comments)
>>>>
>>>> I've kept the testcase logic different to the JRE logic around how
>>>> the new
>>>> property is parsed to better
>>>> test the golden result expectations. (both approaches should be equal)
>>>>
>>>> Regards,
>>>> Sean.
>>
>