<i18n dev> [8] Code review request: 8004489 and 8006509

Yuka Kamiya yuka.kamiya at oracle.com
Sun Jan 20 22:14:46 PST 2013


Hi,

The fix looks ok to me.

Thanks,
--
Yuka

(13/01/21 14:34), Masayoshi Okutsu wrote:
> I've updated the webrev to address some feedback.
>
> - Added @compile -XDignore.symbol.file to CldrFormatNamesTest.java
>
> - Added the Unicode copyright to FormatData_be.java, FormatData_is.java, and FormatData_zh_TW.java.
>
> - Removed a System.out.println for debugging from CLDR Converter tool.
>
> - Removed redundant variable initialization in CalendarDataUtility.normalizeCalendarType(String).
>
> Revised webrev:
> http://cr.openjdk.java.net/~okutsu/8/8004489.8006509/webrev.01/
>
> Thanks,
> Masayoshi
>
> On 1/21/2013 1:28 AM, Masayoshi Okutsu wrote:
>> Hi,
>>
>> This is a code review request for two RFEs.
>>
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8004489
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006509
>>
>> Webrev:
>> http://cr.openjdk.java.net/~okutsu/8/8004489.8006509/webrev.00/
>>
>> I didn't add the resources starting with "cldr." to LocaleData this time. Those should be added when JSR 310 resources requirements get clearer.
>>
>> Thanks,
>> Masayoshi
>>
>



More information about the i18n-dev mailing list