<i18n dev> [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era

Alan Bateman Alan.Bateman at oracle.com
Tue Jul 22 13:32:18 UTC 2014


On 22/07/2014 14:06, Masayoshi Okutsu wrote:
> :
>
>> Other minor comments in passing. The changes to 
>> LocalGregorianCalendar.parseEraEntry highlight that it is still using 
>> StringTokenizer, there might an opportunity to use String split here 
>> instead.
>
> But split() uses regex, which I think is too expensive for this simple 
> parsing. The parser wouldn't be used too often, though.
String.split has a fast-path for simple usages like this. It's not core 
to what you are doing here of course, I only mentioned it because 
StringTokener is legacy.

-Alan



More information about the i18n-dev mailing list