<i18n dev> [9] RFR: 8048123: Replace calendars.properties with another mechanism to specify a new Japanese calendar era
Masayoshi Okutsu
masayoshi.okutsu at oracle.com
Tue Jul 22 13:06:41 UTC 2014
On 7/22/2014 9:49 PM, Alan Bateman wrote:
> There are a couple of @SuppressWarnings values that I don't recognize,
> are these warnings that javac emits?
These are what netbeans complained and suggested. So I assume that these
warnings are all from javac.
> Other minor comments in passing. The changes to
> LocalGregorianCalendar.parseEraEntry highlight that it is still using
> StringTokenizer, there might an opportunity to use String split here
> instead. In getLocalGregorianCalendar you could use a lambda as has
> been done in a few other places.
But split() uses regex, which I think is too expensive for this simple
parsing. The parser wouldn't be used too often, though. This time I
didn't change things netbeans didn't complain.
Thanks,
Masayoshi
More information about the i18n-dev
mailing list