<i18n dev> RFR: 8037180: [TEST_BUG] test/sun/util/calendar/zi/Zoneinfo.java incorrectly calculates raw GMT offset change time

[Masayoshi Okutsu]

+1

Masayoshi

On 3/13/2014 9:19 PM, Seán Coffey wrote:
> Looks good Aleksej. A future rule change doesn't necessarily mean a 
> new GMT offset change. Original test logic seemed buggy.
>
> regards,
> Sean.
>
> On 12/03/2014 15:06, Aleksej Efimov wrote:
>> Hello,
>>
>> Can I have a review for a 'test/sun/util/calendar/zi/Zoneinfo.java' 
>> test bug failure [1] related to the latest tzdata2014a integration [2].
>> The test failure message:
>> Asia/Istanbul : Asia/Istanbul
>> offset=7200000,dstSavings=3600000,useDaylight=true,transitions=171,offsets=5,checksum=-508379603,gmtChanged=false 
>>
>> [NG]offset=7200000,dstSavings=3600000,useDaylight=true,transitions=171,offsets=5,checksum=-508379603,gmtChanged=true 
>>
>>     ----------System.err:(13/732)----------
>> java.lang.RuntimeException:   FAILED:  Asia/Istanbul
>>         at TestZoneInfo310.main(TestZoneInfo310.java:170)
>>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>         at 
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>         at 
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>         at java.lang.reflect.Method.invoke(Method.java:484)
>>         at 
>> com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:94)
>>         at java.lang.Thread.run(Thread.java:744)
>>
>> This failure caused by the following entry in test tzdata files:
>> Zone    Europe/Istanbul 1:55:52 -       LMT     1880
>>                         1:56:56 -       IMT     1910 Oct # Istanbul 
>> Mean Time?
>>                         2:00    Turkey  EE%sT   1978 Oct 15
>>                         3:00    Turkey  TR%sT   1985 Apr 20 # Turkey 
>> Time
>>                         2:00    Turkey  EE%sT   2007
>>                         2:00    EU      EE%sT   2011 Mar 27 1:00u
>>                         2:00    -       EET     2011 Mar 28 1:00u
>>                         2:00    EU      EE%sT   2014 Mar 30 1:00u
>>                         2:00    -       EET     2014 Mar 31 1:00u
>>                         2:00    EU      EE%sT
>>
>> The raw GMT offset here is constant=2:00 and not changed since 1985 
>> Apr 20. But the test code 'test/sun/util/calendar/zi' shows that 
>> there will be a future raw GMT offset change. The following fix 
>> resolves this problem: 
>> http://cr.openjdk.java.net/~aefimov/8037180/9/webrev.00/
>>
>> -Aleksej
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8037180
>> [2] https://bugs.openjdk.java.net/browse/JDK-8037012
>