<i18n dev> [9] RFR: 8032650: jdk/src/share/native/java/util: jni exception pending

Naoto Sato naoto.sato at oracle.com
Wed May 21 16:32:36 UTC 2014


OK. Fair enough.

Naoto

On 5/21/26 H, 2:01 AM, Masayoshi Okutsu wrote:
> Yes, we should. But it's a lot of work if we clean up old tools as well.
> I'd like to fix this one first.
>
> Masayoshi
>
> On 5/20/2014 7:20 AM, Naoto Sato wrote:
>> The fix itself looks good to me. However, there are pieces of code
>> that deal with Windows releases that are no longer supported. Should
>> we remove those dead code?
>>
>> Naoto
>>
>> On 5/19/26 H, 1:10 AM, Masayoshi Okutsu wrote:
>>> Hello,
>>>
>>> Could you please review the fix for 8032650? The bug report isn't
>>> visible outside Oracle. The problem is that the second call to
>>> JNU_GetStringPlatformChars() in
>>> Java_java_util_TimeZone_getSystemTimeZoneID() in
>>> src/share/native/java/util/TimeZone.c ignores possible exceptions. I
>>> decided to eliminate the `country' argument from the function, which
>>> eliminates the call. `country' used to be used in old Windows to
>>> distinguish combined time zones, but it's no longer useful. (bestMatch
>>> in src/windows/native/java/util/TimeZone_md.c doesn't work well.)
>>>
>>> bug report:
>>> https://bugs.openjdk.java.net/browse/JDK-8032650
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~okutsu/9/8032650/webrev.00/
>>>
>>> Thanks,
>>> Masayoshi
>>>
>


More information about the i18n-dev mailing list