<i18n dev> [8u60] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

Masayoshi Okutsu masayoshi.okutsu at oracle.com
Mon Apr 20 06:27:46 UTC 2015


I've changed the variable name to getDynamicTimeZoneInfoFunc to avoid 
that confusion.

http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.01/

I will push the changed one.

Thanks,
Masayoshi

On 4/18/2015 9:05 AM, Naoto Sato wrote:
> My only comment is that it could be confusing to use the same name 
> "getDynamicTimeZoneInfo" for the function name and the proc address 
> variable name (initially I thought if it were a recursive call). 
> Otherwise it looks good to me.
>
> Also approving the backport to 8u.
>
> Naoto
>
> On 4/17/15 1:16 AM, Masayoshi Okutsu wrote:
>> Hello,
>>
>> Please review and approve the 8u version of the fix for JDK-7044727.
>> This fix is different from the jdk9 one to be buildable and runnable on
>> Windows XP.
>>
>> issue: https://bugs.openjdk.java.net/browse/JDK-7044727
>> 8u webrev: http://cr.openjdk.java.net/~okutsu/8u/7044727/webrev.00/
>>
>> jdk9 review thread:
>> http://mail.openjdk.java.net/pipermail/i18n-dev/2015-April/001665.html
>> jdk9 webrev: http://cr.openjdk.java.net/~okutsu/9/7044727/webrev.00/
>> jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ff7cdc646abd
>>
>> Thanks,
>> Masayoshi
>>



More information about the i18n-dev mailing list