<i18n dev> [PATCH] preserve records order in generated tzdb.dat

Alex Kashchenko mail at alexkasko.com
Mon Apr 20 17:19:17 UTC 2015


Hi,

I noticed that "not-linked" HashSet and HashMap are used during the 
compilation of zone info data into tzdb.dat. This causes 
non-deterministic order of records in tzdb.dat. While order there is not 
important for java.util.TimeZone I thought that deterministic order will 
be better.

I prepared webrevs for jdk9:

  - http://cr.openjdk.java.net/~akasko/jdk9/tzdbgen_linked/webrev.00/
  - http://cr.openjdk.java.net/~akasko/jdk9/tzdbgen_linked/webrev.00.zip

and jdk8u:

  - http://cr.openjdk.java.net/~akasko/jdk8u/tzdbgen_linked/webrev.00/
  - http://cr.openjdk.java.net/~akasko/jdk8u/tzdbgen_linked/webrev.00.zip

The actual different order is quite hard to reproduce, I spotted this 
running TzdbZoneRulesCompiler on different versions of OpenJDK. So there 
is no test.

Please let me know, if JBS bug should be created (have access as an 
Author but never did it before), if jdk8u change should be posted 
separately and later etc.

Thanks.

-- 
-Alex


More information about the i18n-dev mailing list