<i18n dev> Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

[Yuka Kamiya]

Hi,

The fix looks good to me.

Thanks,
--
Yuka


On 2015/11/20 19:20, Naveen Kumar wrote:
> Hi,
>      Please consider this updated webrev.01 for the review of bug 
> JDK-8073211
>
> Bug:            https://bugs.openjdk.java.net/browse/JDK-8073211
> webrev: http://cr.openjdk.java.net/~okutsu/naveen/8073211/webrev.01/
>
> updates in fix:
>                           Masayoshi pointed out that there was already 
> a NullPointerException for pos. So I have merged both of them like this:
>
> * @throws NullPointerException if {@code source} or {@code pos} is null.
>
>
> Sorry for posting it multiple times.
>
>
> regards
> Naveen
>
> On 11/20/2015 3:43 PM, Naveen Kumar wrote:
>> Hi,
>>      Please consider this updated webrev.01 for the review of bug 
>> JDK-8073211
>>
>> Bug:            https://bugs.openjdk.java.net/browse/JDK-8073211
>> webrev: http://cr.openjdk.java.net/~okutsu/naveen/8073211/webrev.01/
>>
>> updates in fix:
>>                           Masayoshi pointed out that there was 
>> already a NullPointerException for pos. So I have merged both of them 
>> like this:
>>
>> * @throws NullPointerException if {@code source} or {@code pos} is 
>> null. regards Naveen
>>
>>
>>
>> On 11/20/2015 2:28 AM, Naoto Sato wrote:
>>> Looks good to me.
>>>
>>> Naoto
>>>
>>> On 11/19/15 11:31 AM, Naveen Kumar wrote:
>>>> Hi All,
>>>>            Please review the following fix in API doc for jdk9
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8073211
>>>> webrev: http://cr.openjdk.java.net/~naoto/naveen/8073211/webrev.00/
>>>>
>>>> Issue:
>>>>
>>>> The 2 parseObject methods in java.text.Format throw a
>>>> NullPointerException if the parameter "source" is null. However, 
>>>> this is
>>>> not specified in the javadoc. Please note that this should also be
>>>> checked & corrected in all subclasses of java.text.Format
>>>>
>>>> Fix:
>>>>        Documentations of 
>>>> /java.text.Format.parseObject(java.lang.String,
>>>> java.text.ParsePosition)/,
>>>> /java.text.Format.parseObject(java.lang.String)/,
>>>> /java.text.MessageFormat.parseObject(java.lang.String,
>>>> java.text.ParsePosition)/,
>>>> /java.text.DateFormat.parseObject(java.lang.String,
>>>> java.text.ParsePosition)/,
>>>> /java.text.NumberFormat.parseObject(java.lang.String,
>>>> java.text.ParsePosition)/ are updated with the following addition:
>>>>
>>>> * @throws NullPointerException if {@code source} is null.
>>>>
>>>>
>>>> regards
>>>> Naveen Kumar
>>
>