<i18n dev> [10] RFR JDK-8186713: Document default rounding mode in NumberFormat

Nishit Jain nishit.jain at oracle.com
Mon Aug 28 07:43:55 UTC 2017


Hi Brian,

 > L178-195: Is a list necessary here?
The list approach is used to clearly mention that these two points are 
under "Implementation Requirements". If it does not look good, another 
way could be to use @implSpec tag for individual points, separated by 
<p>. Please check if this is fine.

Also updated the webrev with other suggested changes.

http://cr.openjdk.java.net/~nishjain/8186713/webrev.01/

Regards,
Nishit Jain
On 25-08-2017 00:55, Brian Burkhalter wrote:
> A few minor comments:
>
> L178-195: Is a list necessary here?
>
> L186: I don’t think “<b>Rounding</b>: " is necessary.
>
> L187: s/the numbers/numbers/
>
> L188: s/uses/uses the/
>
> L191: s/its/the/
>
> Thanks,
>
> Brian
>
> On Aug 24, 2017, at 12:06 AM, Nishit Jain <nishit.jain at oracle.com 
> <mailto:nishit.jain at oracle.com>> wrote:
>
>> Webrev:http://cr.openjdk.java.net/~nishjain/8186713/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Enishjain/8186713/webrev.00/>
>



More information about the i18n-dev mailing list