<i18n dev> RFR: 8274544: Langtools command's usage were garbled on Japanese Windows [v5]
Naoto Sato
naoto at openjdk.java.net
Wed Nov 3 18:44:17 UTC 2021
On Mon, 1 Nov 2021 16:10:26 GMT, Ichiroh Takiguchi <itakiguchi at openjdk.org> wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with PrintStream.
>
> Ichiroh Takiguchi has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>
> - 8274544: Langtools command's usage were garbled on Japanese Windows
> - 8274544: Langtools command's usage were garbled on Japanese Windows
> - 8274544: Langtools command's usage were garbled on Japanese Windows
> - 8274544: Langtools command's usage were garbled on Japanese Windows
> - Langtools command's usage were grabled on Japanese Windows
Firstly, please do NOT rebase your fix, as it will clobber the review history. Use merge instead.
As to the fix, I am not sure consolidating the code into Log.java would be OK as it would introduce module dependency.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5771
More information about the i18n-dev
mailing list