<i18n dev> RFR: JDK-8285932 Implementation of JEP-430 String Templates (Preview) [v21]

[Jim Laskey]

On Wed, 16 Nov 2022 13:12:49 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/java.base/share/classes/java/lang/runtime/TemplateRuntime.java line 115:
> 
>> 113:      * @throws Throwable            if linkage fails
>> 114:      */
>> 115:     public static CallSite stringTemplateBSM(
> 
> In other classes in this package we never use `BSM` in the bootstrap name. Instead, we make some attempt to describe what the BSM does by picking some meaningful name (see SwitchBootstrap::typeSwitch). I think `newStringTemplate` (or `make`, `create`) would work here?

Reasonable. Changing.

> src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java line 227:
> 
>> 225:     // templated string
>> 226:     public final Name process;
>> 227:     public final Name str;
> 
> We have precedents for using capital variable names in this class, and we should probably do so here (for `str` and `raw`).

Changing.

-------------

PR: https://git.openjdk.org/jdk/pull/10889