<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v21]

[Jim Laskey]

On Wed, 16 Nov 2022 15:22:43 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrong line separator
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 125:
> 
>> 123:     }
>> 124: 
>> 125:     Type makeListType(Type elemType) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 136:
> 
>> 134:     }
>> 135: 
>> 136:     JCVariableDecl makeField(JCClassDecl cls, long flags, Name name, Type type, JCExpression init) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 149:
> 
>> 147:     }
>> 148: 
>> 149:     JCFieldAccess makeThisFieldSelect(Type owner, JCVariableDecl field) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 156:
> 
>> 154:     }
>> 155: 
>> 156:     JCIdent makeParamIdent(List<JCVariableDecl> params, Name name) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 171:
> 
>> 169:     }
>> 170: 
>> 171:     JCMethodInvocation makeApply(JCFieldAccess method, List<JCExpression> args) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 179:
> 
>> 177:     }
>> 178: 
>> 179:     JCFieldAccess makeFieldAccess(JCClassDecl owner, Name name) {
> 
> Unused

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 223:
> 
>> 221:         JCStringTemplate tree;
>> 222:         JCExpression processor;
>> 223:         List<String> fragments;
> 
> I still believe some of these fields could be final

Changing

> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransLiterals.java line 318:
> 
>> 316:                         staticArgValues, staticArgsTypes);
>> 317:             } else {
>> 318:                 VarSymbol processorSym = (VarSymbol)TreeInfo.symbol(processor);
> 
> This seems unused

Changing

-------------

PR: https://git.openjdk.org/jdk/pull/10889