<i18n dev> RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v2]

[Lance Andersen]

On Tue, 18 Oct 2022 17:28:49 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47:
> 
>> 45:     private static final String TZ_UP = "US/Pacific";
>> 46:     // Asia/Novosibirsk time zone
>> 47:     private static final String TZ_AN = "Asia/Novosibirsk";
> 
> IMO it's not necessary to create constants if they'll only be used as a ValueSource

True, but really a personal choice as it makes the ValueSource less wordy ;-)

> test/jdk/java/util/Formatter/BasicTestLauncher.java line 49:
> 
>> 47:     private static final String TZ_AN = "Asia/Novosibirsk";
>> 48:     // Locale flag for testJVM
>> 49:     private static final String LOCALE_PROV = "-Djava.locale.providers=CLDR";
> 
> A name like "JAVA_OPTS" would better express how this value is used.

agree

-------------

PR: https://git.openjdk.org/jdk/pull/10715