<i18n dev> RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

Justin Lu duke at openjdk.org
Fri Oct 28 21:59:53 UTC 2022


Issue: Duplication of methods between Basic*.java test classes, due to auto generation by genBasic.sh

Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove excessive white space. Moved a previous direct change to BasicDateTime.java into the template.

Note: Main files to look at are Basic.java and Basic-X.java.template, as the rest are a reflection of the auto generation

-------------

Commit messages:
 - Add previous hard coded change into template
 - Remove duplicated methods, put into Basic
 - Toggle -nel for gen script

Changes: https://git.openjdk.org/jdk/pull/10910/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10910&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295670
  Stats: 29666 lines in 22 files changed: 1531 ins; 27888 del; 247 mod
  Patch: https://git.openjdk.org/jdk/pull/10910.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10910/head:pull/10910

PR: https://git.openjdk.org/jdk/pull/10910


More information about the i18n-dev mailing list