<i18n dev> RFR: 8295670: Remove duplication in java/util/Formatter/Basic*.java

Brent Christian bchristi at openjdk.org
Fri Oct 28 22:11:27 UTC 2022

On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu <duke at openjdk.org> wrote:

> Issue: Duplication of methods between Basic*.java test classes, due to auto generation by genBasic.sh
> Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. Toggled -nel flag for generation script (genBasic.sh) to remove excessive white space. Moved a previous direct change to BasicDateTime.java into the template.
> Note: Main files to look at are Basic.java and Basic-X.java.template, as the rest are a reflection of the auto generation

Looks good. That sure was a lot of extra newlines!


Marked as reviewed by bchristi (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10910

More information about the i18n-dev mailing list