<i18n dev> RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v56]

Jim Laskey jlaskey at openjdk.org
Thu Apr 13 12:15:51 UTC 2023


On Wed, 12 Apr 2023 15:15:09 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change MAX_INDY_CONCAT_ARG_SLOTS to be updatable.
>
> src/java.base/share/classes/java/lang/runtime/StringTemplateImplFactory.java line 112:
> 
>> 110:         }
>> 111:         interpolateMH = MethodHandles.filterArguments(interpolateMH, 0, components);
>> 112:         mt = MethodType.methodType(String.class, StringTemplateImpl.class);
> 
> This MethodType can be stored in a static final field than created every time on the fly. Don't know if JIT compiler can inline this statement. Same fore that `List.class, StringTemplateImpl.class` type below.

Changing

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1165433226


More information about the i18n-dev mailing list