<i18n dev> RFR: 8311663: Additional refactoring of Locale tests to JUnit

[Andrey Turbanov]

On Thu, 13 Jul 2023 23:23:42 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which refactors more java.util.Locale tests to JUnit with some minor cleanup as well.
> 
> Although some of the files could benefit from being renamed bugNNNNNNN to something more descriptive, this makes reviewing harder, and will be handled separately.

test/jdk/java/util/Locale/Bug8179071.java line 78:

> 76:         return Stream.of(
> 77:                 Arguments.of("pa-PK", "\u0a1c\u0a28"),
> 78:                 Arguments.of("uz-AF" , "yan"),

Suggestion:

                Arguments.of("uz-AF", "yan"),

test/jdk/java/util/Locale/Bug8179071.java line 95:

> 93:                 .forEach(tag -> {if(LegacyAliases.contains(tag)) {invalidTags.add(tag);}});
> 94:         assertEquals(true, invalidTags.isEmpty(),
> 95:                 "Deprecated and Legacy tags found  " + invalidTags  + " in AvailableLocales ");

Suggestion:

                "Deprecated and Legacy tags found  " + invalidTags + " in AvailableLocales ");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14881#discussion_r1265185559
PR Review Comment: https://git.openjdk.org/jdk/pull/14881#discussion_r1265185856