<i18n dev> RFR: 8310923: Refactor Currency tests to use JUnit [v5]

Justin Lu jlu at openjdk.org
Fri Jun 30 07:50:50 UTC 2023


> Please review this PR which refactors Currency tests to use JUnit.
> 
> The most significant change occurs in `ValidateISO4217.java`. Other changes to this file excluding the JUnit refactoring include
> 
> - Tests are no longer dependent on each other (order of execution does not matter)
> - Testing does not occur at the same time as data generation (The data is fully generated before any tests are executed)
> - Various cleanup (dead-code, clarifying comments, more descriptive method and var names)
> 
> `Bug4512215.java` now renamed to `MinorUndefinedCodes` was updated to remove redundant testing, and the file changed to focus on testing minor undefined currency codes instead.

Justin Lu has updated the pull request incrementally with five additional commits since the last revision:

 - Further clarification regarding minor undefined currencies
 - Review: Rename MinorUndefinedCodes.java to NoMinorUnitCurrenciesTest.java
 - Review: Update ValidateISO4217.java
 - Review: Rename CurrencyNameProviderTest to be more specific
 - Review: CurrencyTest updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14682/files
  - new: https://git.openjdk.org/jdk/pull/14682/files/10d54167..ba3d2e5d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14682&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14682&range=03-04

  Stats: 196 lines in 5 files changed: 96 ins; 92 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/14682.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14682/head:pull/14682

PR: https://git.openjdk.org/jdk/pull/14682


More information about the i18n-dev mailing list