<i18n dev> RFR: 8310923: Refactor Currency tests to use JUnit [v5]

[Naoto Sato]

On Fri, 30 Jun 2023 07:50:50 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which refactors Currency tests to use JUnit.
>> 
>> The most significant change occurs in `ValidateISO4217.java`. Other changes to this file excluding the JUnit refactoring include
>> 
>> - Tests are no longer dependent on each other (order of execution does not matter)
>> - Testing does not occur at the same time as data generation (The data is fully generated before any tests are executed)
>> - Various cleanup (dead-code, clarifying comments, more descriptive method and var names)
>> 
>> `Bug4512215.java` now renamed to `MinorUndefinedCodes` was updated to remove redundant testing, and the file changed to focus on testing minor undefined currency codes instead.
>
> Justin Lu has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - Further clarification regarding minor undefined currencies
>  - Review: Rename MinorUndefinedCodes.java to NoMinorUnitCurrenciesTest.java
>  - Review: Update ValidateISO4217.java
>  - Review: Rename CurrencyNameProviderTest to be more specific
>  - Review: CurrencyTest updates

test/jdk/java/util/Currency/CurrencyTest.java line 243:

> 241:                 // Old and New Turkish Lira
> 242:                 Arguments.of("TRL", 0), Arguments.of("TRY", 2),
> 243:                 Arguments.of("TND", 3)

Probably `TND` moving upward before the comment would be clearer, like:

                Arguments.of("LYD", 3), Arguments.of("OMR", 3),
                Arguments.of("TND", 3),

                // Old and New Turkish Lira
                Arguments.of("TRL", 0), Arguments.of("TRY", 2)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14682#discussion_r1248059699