<i18n dev> RFR: 8310923: Refactor Currency tests to use JUnit [v5]

Justin Lu jlu at openjdk.org
Fri Jun 30 16:49:22 UTC 2023


On Fri, 30 Jun 2023 16:22:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Further clarification regarding minor undefined currencies
>>  - Review: Rename MinorUndefinedCodes.java to NoMinorUnitCurrenciesTest.java
>>  - Review: Update ValidateISO4217.java
>>  - Review: Rename CurrencyNameProviderTest to be more specific
>>  - Review: CurrencyTest updates
>
> test/jdk/java/util/Currency/CurrencyTest.java line 243:
> 
>> 241:                 // Old and New Turkish Lira
>> 242:                 Arguments.of("TRL", 0), Arguments.of("TRY", 2),
>> 243:                 Arguments.of("TND", 3)
> 
> Probably `TND` moving upward before the comment would be clearer, like:
> 
>                 Arguments.of("LYD", 3), Arguments.of("OMR", 3),
>                 Arguments.of("TND", 3),
> 
>                 // Old and New Turkish Lira
>                 Arguments.of("TRL", 0), Arguments.of("TRY", 2)

Adjusted `TND` upwards

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14682#discussion_r1248079845


More information about the i18n-dev mailing list