<i18n dev> RFR: JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args

Naoto Sato naoto at openjdk.org
Mon Nov 13 19:35:41 UTC 2023


On Sun, 12 Nov 2023 21:39:29 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319868) which makes IllegalArgumentExceptions apparent for the _j.text.DateFormat_ static factory methods that have the _style_ parameter.

src/java.base/share/classes/java/text/DateFormat.java line 68:

> 66:  * styles. The formatting styles include {@link #FULL}, {@link #LONG}, {@link #MEDIUM}, and {@link #SHORT}.
> 67:  * For any of the factory methods with the parameter <i>style</i>, an {@code
> 68:  * IllegalArgumentException} will be thrown if <i>style</i> is not equal to one

I wonder if "not equal to *any* of the ..." may read better here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16624#discussion_r1391596506


More information about the i18n-dev mailing list