<i18n dev> RFR: JDK-8319628: DateFormat does not mention IllegalArgumentException for invalid style args [v2]

[Justin Lu]

On Mon, 13 Nov 2023 19:32:18 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reflect review, one -> any
>
> src/java.base/share/classes/java/text/DateFormat.java line 68:
> 
>> 66:  * styles. The formatting styles include {@link #FULL}, {@link #LONG}, {@link #MEDIUM}, and {@link #SHORT}.
>> 67:  * For any of the factory methods with the parameter <i>style</i>, an {@code
>> 68:  * IllegalArgumentException} will be thrown if <i>style</i> is not equal to one
> 
> I wonder if "not equal to *any* of the ..." may read better here.

Agreed that sounds better. Changed in both the CSR and the PR, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16624#discussion_r1391730654