<i18n dev> RFR: JDK-8317372: Refactor some NumberFormat tests to use JUnit [v2]
Justin Lu
jlu at openjdk.org
Wed Oct 11 21:20:47 UTC 2023
> Please review this PR which refactors a number of tests under `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve readability)
> - separate the test data generation from the actual execution of the test
> - create distinct test methods so that all the tests aren't just run under one big method (e.g. main)
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
Reflect review comments
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16035/files
- new: https://git.openjdk.org/jdk/pull/16035/files/415230bd..22d7e1a6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16035&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16035&range=00-01
Stats: 31 lines in 5 files changed: 6 ins; 0 del; 25 mod
Patch: https://git.openjdk.org/jdk/pull/16035.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16035/head:pull/16035
PR: https://git.openjdk.org/jdk/pull/16035
More information about the i18n-dev
mailing list