<i18n dev> RFR: JDK-8317372: Refactor some NumberFormat tests to use JUnit [v2]

Naoto Sato naoto at openjdk.org
Wed Oct 11 22:02:17 UTC 2023


On Wed, 11 Oct 2023 21:20:47 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Please review this PR which refactors a number of tests under `test/text/NumberFormat` to use JUnit.
>> 
>> During the switch to JUnit, the tests had the following updates (to improve readability)
>> - separate the test data generation from the actual execution of the test
>> - create distinct test methods so that all the tests aren't just run under one big method (e.g. main)
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reflect review comments

test/jdk/java/text/Format/NumberFormat/Bug8132125.java line 47:

> 45:         NumberFormat nf = NumberFormat.getInstance(deCH);
> 46: 
> 47:         // "\u2019" as decimal separator, "\u002E" as grouping separator

"\u002E" is decimal, "\u2019" is grouping.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16035#discussion_r1355824830


More information about the i18n-dev mailing list