<i18n dev> RFR: 6228794: java.text.ChoiceFormat pattern behavior is not well documented. [v5]
Justin Lu
jlu at openjdk.org
Fri Sep 8 21:11:11 UTC 2023
On Fri, 8 Sep 2023 20:21:56 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Make starting sentence consistent with other Format classes. Improve wording, a choiceFormat does NOT have to be created with only the arrays constructor.
>> - Improve throws description for input that takes pattern
>> - Make Format definition more consistent with other Format classes
>
> src/java.base/share/classes/java/text/ChoiceFormat.java line 155:
>
>> 153: * "#" / "<" / "≤"
>> 154: * <i>Format:</i>
>> 155: * Any unicode characters except the <i>Relation</i> symbols
>
> Nit: since characters in Java are of Unicode code points, no need to mention `unicode` here.
Thanks for the follow-up review. Fixed the nit, and updated the [CSR](https://bugs.openjdk.org/browse/JDK-8314546) to reflect all of the changes.
(I used the 'Unicode' wording because the other Format classes did, I will adjust it for the other classes in this [issue](https://bugs.openjdk.org/browse/JDK-8315946)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15392#discussion_r1320340696
More information about the i18n-dev
mailing list