<i18n dev> RFR: JDK-8316559: Refactor some util/Calendar tests to JUnit [v2]
Lance Andersen
lancea at openjdk.org
Fri Sep 22 20:48:12 UTC 2023
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR which converts some tests under _Calendar_ to use JUnit. These tests either previously used the internal _IntlTest_, or used no framework at all.
>>
>> Any files named BugXXXXXXX.java will be renamed after review.
>
> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>
> - Review: revert removal of SupressWarnings annotation
> - Reflect review comments
Overall, this is fine.
I would like to suggest comments to introduce all tests and DataProviders. Extra credit for helper methods.
>From a future maintainers Point of view, having more info in the tests is beneficial.
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15853#pullrequestreview-1640620487
More information about the i18n-dev
mailing list