<i18n dev> RFR: 8346773: Fix unmatched brackets in source files [v2]
Qizheng Xing
qxing at openjdk.org
Tue Dec 24 03:32:36 UTC 2024
On Mon, 23 Dec 2024 19:13:09 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Qizheng Xing has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch upstream data from CLDR.
>
> test/hotspot/jtreg/testlibrary/ctw/Makefile line 50:
>
>> 48: $(TESTLIBRARY_DIR)/jdk/test/lib/util \
>> 49: $(TESTLIBRARY_DIR)/jtreg \
>> 50: -maxdepth 1 -name '*.java')
>
> I wonder why this hasn't caused problems and been found long ago? Does make just drop that stray
> close-paren?
I've tested this by running `make`, and the previous Makefile reports an error like file `test/lib/jtreg/SkippedException.java)` not found. So this fix is necessary.
I also checked the git log, this change was introduced in https://github.com/openjdk/jdk/pull/22420, not that long ago.
> test/jaxp/javax/xml/jaxp/unittest/transform/Bug8169112.xsl line 65:
>
>> 63: @page { margin: 0.1in; }
>> 64:
>> 65: }
>
> Does this affect the behavior of the test this is part of?
Reverted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896336118
PR Review Comment: https://git.openjdk.org/jdk/pull/22861#discussion_r1896337303
More information about the i18n-dev
mailing list