<i18n dev> RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v2]

Naoto Sato naoto at openjdk.org
Tue Mar 26 22:34:23 UTC 2024


On Tue, 26 Mar 2024 22:23:45 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> test/jdk/java/text/Format/MessageFormat/CompactSubFormats.java line 29:
>> 
>>> 27:  * @summary Test MessageFormatPattern ability to recognize and produce
>>> 28:  *          appropriate FormatType and FormatStyle for CompactNumberFormat.
>>> 29:  * @run junit/othervm -Duser.language=en -Duser.country=US CompactSubFormats
>> 
>> I would instantiate MessageFormat explicitly with the `US` locale (using the 2-arg constructor), instead of implicitly specifying it with the system property.
>
> Thanks for the review and suggestions, PR should be updated. (I presume you meant the 2-arg Locale.of() method, not the constructor)

I meant using `new MessageFormat(String, Locale.US)`, instead of `new MessageFormat(String)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18498#discussion_r1540192178


More information about the i18n-dev mailing list