<i18n dev> RFR: JDK-8329118: Run MessageFormat additional subformat pattern tests under en_US locale [v3]
Justin Lu
jlu at openjdk.org
Tue Mar 26 23:02:34 UTC 2024
On Tue, 26 Mar 2024 22:32:08 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Thanks for the review and suggestions, PR should be updated. (I presume you meant the 2-arg Locale.of() method, not the constructor)
>
> I meant using `new MessageFormat(String, Locale.US)`, instead of `new MessageFormat(String)`.
Ah, gotchu. Updated with the two arg `MessageFormat` constructor, although I think it would have been fine previously as well just passing the locale in directly to the subformat.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18498#discussion_r1540210872
More information about the i18n-dev
mailing list