<i18n dev> RFR: 8373830: Refactor test/jdk/java/time/test tests to use JUnit over TestNG [v2]

Justin Lu jlu at openjdk.org
Fri Dec 19 19:52:34 UTC 2025


> Please review this PR which migrates the java.time tests from TestNG to JUnit. The java.time tests use TestNG based on the directory level settings configured by TEST.properties, so they are best migrated altogether. This is a large PR, so I have tried to make the changes clear by commit.
> 
> First, the auto conversion tool is run in https://github.com/openjdk/jdk/commit/b1fd7dbdec85aac5a44cc875e57a36be8f1b6974.
> https://github.com/openjdk/jdk/commit/3805cfd8765c0c76b61893dcf1670951402f98c3 and https://github.com/openjdk/jdk/commit/b697ca5d9a8067bcecea2dfb32f92f7699085dee are required so that the tests can actually compile and run.
> https://github.com/openjdk/jdk/commit/d07c912c4c16d2b3307e489563f148f71cfdf4a4 addresses the timeout annotation which was not covered by the auto conversion tool.
> The rest of the commits are aesthetic related.
> 
> Before conversion stats
> 
> 
> Test results: passed: 187
> Framework-based tests: 32,339 = 32,339 TestNG + 0 JUnit
> 
> 
> After conversion stats
> 
> 
> Test results: passed: 187
> Framework-based tests: 32,339 = 0 TestNG + 32,339 JUnit

Justin Lu has updated the pull request incrementally with two additional commits since the last revision:

 - nontestng -> nonjunit
 - Fix comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28911/files
  - new: https://git.openjdk.org/jdk/pull/28911/files/d07c912c..d90d23ed

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28911&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28911&range=00-01

  Stats: 3 lines in 11 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/28911.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28911/head:pull/28911

PR: https://git.openjdk.org/jdk/pull/28911


More information about the i18n-dev mailing list