<i18n dev> RFR: 8373830: Refactor test/jdk/java/time/test tests to use JUnit over TestNG [v2]

Justin Lu jlu at openjdk.org
Fri Dec 19 19:52:36 UTC 2025


On Fri, 19 Dec 2025 18:33:13 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - nontestng -> nonjunit
>>  - Fix comments
>
> test/jdk/java/time/tck/java/time/chrono/serial/TCKChronoLocalDateSerialization.java line 89:
> 
>> 87:     static final int HIJRAH_DATE_TYPE = 6;       // java.time.chrono.Ser.HIJRAH_DATE_TYPE
>> 88:     static final int MINGUO_DATE_TYPE = 7;       // java.time.chrono.Ser.MINGUO_DATE_TYPE
>> 89:     static final int THAIBUDDHIST_DATE_TYPE = 8; // java.time.chrono.Ser.THAIBUDDHIST_DATE_TYPE// java.time.chrono.Ser.THAIBUDDHIST_DATE_TYPE
> 
> The comment seems duplicated for no apparent reason. (Tool's bug?)

Thanks for spotting, it does appear to be left by the tool. I searched for other occurrences and did not find any besides the ones you mentioned.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28911#discussion_r2636118993


More information about the i18n-dev mailing list