<i18n dev> RFR: 8349000: Performance improvement for Currency.isPastCutoverDate(String) [v2]
Justin Lu
jlu at openjdk.org
Fri Jan 31 19:46:37 UTC 2025
> Please review this PR which improves the performance of cut-over date checking when the user supplies a properties override via the `java.util.currency.data` sys prop. Replacing the `SimpleDateFormat` with a _java.time_ alternative has better performance. It should be noted that this method is only entered when the string `s` is confirmed to adhere to the format: `yyyy-MM-ddTHH:mm:ss`.
>
> An alternative is using `LocalDateTime.of(..)` and extracting the date/time values ourselves from `s` with the known positions which is considerably faster but not as concise.
Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
generalize format comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23374/files
- new: https://git.openjdk.org/jdk/pull/23374/files/0f1c27f3..a71a31bc
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23374&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23374&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/23374.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23374/head:pull/23374
PR: https://git.openjdk.org/jdk/pull/23374
More information about the i18n-dev
mailing list