<i18n dev> RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Thu Jul 17 13:50:50 UTC 2025
On Thu, 17 Jul 2025 13:41:06 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added comment to COMPAT static field.
>
> src/java.base/share/classes/jdk/internal/math/FormattedFPDecimal.java line 51:
>
>> 49:
>> 50: private boolean exact; // this decimal is an exact fp
>> 51: private boolean away; // this decimal has a larger magnitude than fp
>
> Drive by comment.
> The name "away" doesn't convey enough information nor the implications. A longer comment somewhere might be in order.
This is IEEE 754 jargon to say "away from zero", so towards the same signed infinity.
I'll make the comment clearer in the next commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2213403030
More information about the i18n-dev
mailing list