<i18n dev> RFR: 8362448: Make use of the Double.toString(double) algorithm in java.text.DecimalFormat [v2]

[Justin Lu]

On Thu, 17 Jul 2025 12:28:06 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added comment to COMPAT static field.

Thanks for working on this Raffaello, the `DecimalFormat` and `DigitList` changes look good to me. Also, the JBS issue needs a `noreg-.*` tag.

src/java.base/share/classes/java/text/DigitList.java line 292:

> 290: 
> 291:     /*
> 292:      * This compatibility option will only be available for a *very* limited

I suppose the number of releases is dependent on if we run into any issues with this change. I'm wondering when is a good time to revisit this for removal. (I guess a few releases means maybe before the next LTS.)

src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 1769:

> 1767:      * fields (> 550 lines).
> 1768:      */
> 1769:     private static BinaryToASCIIConverter getCompatBinaryToASCIIConverter(double d, boolean isCompatibleFormat) {

Can we just remove the `isCompatibleFormat` param and pass true to `buf.dtoa` which should always be true as indicated by the method name and its usage?

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26364#pullrequestreview-3030364252
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2213876548
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2213961792