RFR: 8214856 : Errors with JSZip in web console after upgrade to 3.1.5
Hannes Wallnoefer
hannes.wallnoefer at oracle.com
Wed Dec 5 12:57:49 UTC 2018
+1
Hannes
Am 05.12.18 um 13:44 schrieb Priya Lakshmi Muthuswamy:
> oops sorry for the tabs.
>
> updated webrev :
> http://cr.openjdk.java.net/~pmuthuswamy/8214856/webrev.01/
>
> Thanks,
> Priya
>
> On 12/5/2018 5:33 PM, Hannes Wallnöfer wrote:
>> Am 05.12.2018 um 12:52 schrieb Hannes Wallnoefer
>> <hannes.wallnoefer at oracle.com>:
>>> A minor formatting related issue: the indentation of the closing
>>> braces/parentheses looks a bit random.
>> More precisely: indentation mixes spaces and tabs.
>>
>>
>>> Otherwise +1.
>>>
>>> Hannes
>>>
>>> Am 05.12.18 um 12:28 schrieb Priya Lakshmi Muthuswamy:
>>>> Hi,
>>>>
>>>> Kindly review the fix for
>>>> https://bugs.openjdk.java.net/browse/JDK-8214856
>>>> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8214856/webrev.00/
>>>>
>>>> In JSZip 3.x few api's have changed. Made the changes according to
>>>> the JSZip upgrade
>>>> guidelines(https://stuk.github.io/jszip/documentation/upgrade_guide.html).
>>>>
>>>> Thanks,
>>>> Priya
>>>>
>>>>
More information about the javadoc-dev
mailing list