RFR: JDK-8214468 : jQuery UI upgrade from 1.11.4 to 1.12.1

Hannes Wallnöfer hannes.wallnoefer at oracle.com
Wed Dec 5 13:57:35 UTC 2018


Hi Priya, 

Could it be that you included jQuery UI components that were not included in the previous version and are not used in javadoc?

From the changes in the style sheet, it looks like you add CSS definitions that were not there previously for the following components:

resizable, selectable, sortable, accordion, button, checkboxradio, controlgroup, datepicker, dialog, progress bar, selectmen, slider, spinner, tabs, tooltip.

The generated API docs look good and seem to be working fine.

Hannes


> Am 29.11.2018 um 09:44 schrieb Priya Lakshmi Muthuswamy <priya.lakshmi.muthuswamy at oracle.com>:
> 
> Hi,
> 
> Kindly review the changes for jQuery UI upgrade from 1.11.4 to 1.12.1 (https://bugs.openjdk.java.net/browse/JDK-8214468).
> 
> Modifications done:
> 1) As per the jQuery UI upgrade guidelines, we need to put wrappers around each menu item
> 2) Performance has degraded after updating to 1.12.4.
>      Jquery UI bug : https://bugs.jqueryui.com/ticket/10050
>      After applying suggestions in https://stackoverflow.com/questions/40782638/jquery-autocomplete-performance-going-down-with-each-search, its better.
> 3) Default theme has changed. It was smoothness theme in 1.11.4, its now base theme in 1.12.4.
>     Using the Theme roller, used the smoothness theme and changed the hover color so that its similar to current Javadoc.
> 
> webrev: http://cr.openjdk.java.net/~pmuthuswamy/8214468/webrev.00
> api : http://cr.openjdk.java.net/~pmuthuswamy/8214468/api
> 
> 
> Thanks,
> Priya
> 



More information about the javadoc-dev mailing list