RFR: 8196027: Remove "Prev" and "Next" links from the javadoc navigation

Jonathan Gibbons jonathan.gibbons at oracle.com
Thu Jan 25 00:44:31 UTC 2018



On 01/24/2018 01:25 PM, Bhavesh Patel wrote:
> Hi,
>       Please review the fix for change in javadoc navigation bar.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8196027.
>
> Webrev: http://cr.openjdk.java.net/~bpatel/8196027/webrev.00/
>
> Regards,
> Bhavesh.


In SplitIndexWriter, there are still remnants remaining, such as 
prev/next fields.
See lines 63-73.

In Contents, there are more remnants, such as the set of prev/next labels.
See lines 143-147, 158-162

In the new test, checkOutput(file, false, ...) tests are notoriously 
weak and fragile.
In general you want to make them as broad as possible. To that end, I 
would suggest
turning most "+" in lines 81-111 into a comma at the end of the previous 
line,
and reduce all the strings down to either "Next"/"Prev" or 
"Next&nbspWORD"/"Prev WORD".

-- Jon


More information about the javadoc-dev mailing list