RFR [16,test] JDK-8152313 convert tool tests to doclet tests

Jonathan Gibbons jonathan.gibbons at oracle.com
Sat Jun 13 02:44:51 UTC 2020


Please review updates to 3 javadoc test that have been on the 
ProblemList since JDK 9.

The edits are conceptually minimal, simply updating the tests to use the 
current
Doclet and JavadocTester infrastructure.  The tests are "not great" and 
so I don't
think it's worth a lot of effort to make them substantially better, but 
as long as
they are around, it's better that they are not on the ProblemList file.

The test classes were renamed to reduce the number of test classes all 
called Main.

Two of the tests used a somewhat broken 'printClass' method from the old 
Tester
framework. Rather than provide a full replacement for that method, I 
have just
provided enough for the test to work as expected. That being said, the 
original
method was inconsistent with regard to using simple or qualified names 
for types,
and rather than replicate the same inconsistency, I have fixed that 
issue, and the
corresponding golden files.

It was interesting/educational to be playing around with toy/custom doclets.

-- Jon

JBS: https://bugs.openjdk.java.net/browse/JDK-8152313
Webrev: http://cr.openjdk.java.net/~jjg/8152313/webrev.00/index.html



More information about the javadoc-dev mailing list