RFR [16,test] JDK-8152313 convert tool tests to doclet tests

[Kumar Srinivasan]

Hi Jon,

Thanks for dealing with these.

> On Jun 12, 2020, at 7:44 PM, Jonathan Gibbons <jonathan.gibbons at oracle.com> wrote:
> 
> Please review updates to 3 javadoc test that have been on the ProblemList since JDK 9.
> 
> The edits are conceptually minimal, simply updating the tests to use the current
> Doclet and JavadocTester infrastructure.  The tests are "not great" and so I don't
> think it's worth a lot of effort to make them substantially better, but as long as
> they are around, it's better that they are not on the ProblemList file.

+1 some of these tests are really testing the old *Doc structure.

> 
> The test classes were renamed to reduce the number of test classes all called Main.
> 
> Two of the tests used a somewhat broken 'printClass' method from the old Tester
> framework. Rather than provide a full replacement for that method, I have just
> provided enough for the test to work as expected. That being said, the original
> method was inconsistent with regard to using simple or qualified names for types,
> and rather than replicate the same inconsistency, I have fixed that issue, and the
> corresponding golden files.

I vaguely recall I had to write a printClass like methods which were ports from the old tool tests.


> 
> It was interesting/educational to be playing around with toy/custom doclets.

:) I had to write many of these.


Nit:
test/langtools/jdk/javadoc/tool/varArgs/VarArgsTest.java
"Verify the contents of a ClassDoc containing a varArgs method."

We don’t have a ClassDoc anymore right, but it is not TypeElement either.
Maybe Class Page or something.

I am good with the changes.

Kumar




> 
> -- Jon
> 
> JBS: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.openjdk.java.net%2Fbrowse%2FJDK-8152313&data=02%7C01%7Ckusrinivasan%40vmware.com%7C1c6765f43c7149f98bfa08d80f43e222%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637276131546548683&sdata=QzwKthkaDzPhrywIMWkLPs8nsqk1akN9p8NepuHxUhY%3D&reserved=0
> Webrev: https://nam04.safelinks.protection.outlook.com/?url=http:%2F%2Fcr.openjdk.java.net%2F~jjg%2F8152313%2Fwebrev.00%2Findex.html&data=02%7C01%7Ckusrinivasan%40vmware.com%7C1c6765f43c7149f98bfa08d80f43e222%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637276131546548683&sdata=3ZoCj7s%2BE4DiRMwD0KwkJJiQvbAqa6%2F5aAd1SsR5fRg%3D&reserved=0
>