RFR: JDK-8261079: Fix support for @hidden in classes and interfaces [v3]

[Jonathan Gibbons]

On 2/11/21 4:10 AM, Hannes Wallnöfer wrote:
> Thanks for the review, Jon!
>
> I pushed a new commit that should address your concerns. For the lookup of `@hidden` tags in non-included elements I added a new `hasBlockTagUnchecked` method that avoids caching and doclint checking by using  `getDocCommentInfo` as you suggested. Note that this isn't used for the javafx "treatAsPrivate" tag as changing the semantics of an undocumented/internal tag didn't seem like a good idea on second thought.

I agree that there is no need and that we should not change the 
operation of the older `treatAsPrivate` flag.


>
> Regarding the renaming of `overrider` to `overridden`: the old name was a misnomer, the new name actually reflects the meaning of the field as it contains the overridden method, not the overriding one. I actually went the whole way and renamed the nested class as well, from `OverridingMethodInfo` to `OverriddenMethodInfo`.

Understood.

(For my own satisfaction, I may go back and look at the old code, to 
better understand the provenance of the name. That is independent of 
this review.)


-- Jon