RFR: JDK-8223355: Redundant output by javadoc [v2]

Hannes Wallnöfer hannesw at openjdk.java.net
Mon Feb 22 09:17:42 UTC 2021


On Mon, 22 Feb 2021 09:12:17 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a default-on check that "chatty" lines in the output are unique
>>   (primarily about generating files)
>>   
>>   Remove a redundant misleading "Generating" message: it only showed the base filename and if it had shown the full name, it would have been a duplicate
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java line 201:
> 
>> 199: 
>> 200:         HtmlDocletWriter docletWriter = new DocFileWriter(configuration, dfilePath, element, pkg);
>> 201:         configuration.messages.notice("doclet.Generating_0", docletWriter.filename.getPath());
> 
> I guess this is to prevent duplicate output. It could probably have been solved by printing the HTML file's whole path (`docletWriter.filename` just contains the base name), or including the destination path. But I'm not convinced we need to generate a message for each and every file we copy, so it's probably fine as it is.

Please ignore that comment, I just saw there's already a message with the full path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2652


More information about the javadoc-dev mailing list