RFR: JDK-8223355: Redundant output by javadoc [v2]

Jonathan Gibbons jjg at openjdk.java.net
Tue Feb 23 18:30:43 UTC 2021


On Mon, 22 Feb 2021 09:14:48 GMT, Hannes Wallnöfer <hannesw at openjdk.org> wrote:

>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java line 201:
>> 
>>> 199: 
>>> 200:         HtmlDocletWriter docletWriter = new DocFileWriter(configuration, dfilePath, element, pkg);
>>> 201:         configuration.messages.notice("doclet.Generating_0", docletWriter.filename.getPath());
>> 
>> I guess this is to prevent duplicate output. It could probably have been solved by printing the HTML file's whole path (`docletWriter.filename` just contains the base name), or including the destination path. But I'm not convinced we need to generate a message for each and every file we copy, so it's probably fine as it is.
>
> Please ignore that comment, I just saw there's already a message with the full path.

FWIW, based on other recent experiences, I think there is the potential to have more versatile control of which messages to suppress. `-quiet` just does everything. But this is another discussion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2652


More information about the javadoc-dev mailing list