RFR: 8267329: Modernize Javadoc code to use instanceof with pattern matching [v3]

Pavel Rappo prappo at openjdk.java.net
Thu May 20 13:22:32 UTC 2021


On Wed, 19 May 2021 22:04:14 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> My first reaction is in agreement, but upon further inspection it seems that this class is not used by anything in the module. Interestingly its documentation header warns not to rely on its behavior to remain the same.
>
> The documentation header is a standard langtools warnings to all those people that rely on access to javac and javadoc internals.
> 
> Class not used ... wow, correct. I'll file an RFE to investigate and remove it.

> There may be a change in behavior here, for "invalid" arguments, which will now use `.toString()` instead of throwing CCE.

Jon is right about the behavior change. That was a sloppy suggestion on my part. Sorry, Ian; you should revert that to your original version. Jon has created an RFR to remove LinkOutputImpl and LinkOutput: https://git.openjdk.java.net/jdk/pull/4121

-------------

PR: https://git.openjdk.java.net/jdk/pull/4105


More information about the javadoc-dev mailing list