RFR: 8267329: Modernize Javadoc code to use instanceof with pattern matching [v3]

[Pavel Rappo]

On Thu, 20 May 2021 13:20:01 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> The documentation header is a standard langtools warnings to all those people that rely on access to javac and javadoc internals.
>> 
>> Class not used ... wow, correct. I'll file an RFE to investigate and remove it.
>
>> There may be a change in behavior here, for "invalid" arguments, which will now use `.toString()` instead of throwing CCE.
> 
> Jon is right about the behavior change. That was a sloppy suggestion on my part. Sorry, Ian; you should revert that to your original version. Jon has created an RFR to remove LinkOutputImpl and LinkOutput: https://git.openjdk.java.net/jdk/pull/4121

Correction. Instead of reverting to your original version, you should change it to this:


    @Override
    public void append(Object o) {
        output.append(o instanceof String s ? s : ((LinkOutputImpl) o).toString());
    }

-------------

PR: https://git.openjdk.java.net/jdk/pull/4105