RFR: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag [v2]

Andrey Turbanov aturbanov at openjdk.org
Mon Jul 4 15:09:50 UTC 2022


> Instead of pair `LinkedHashMap.get`+`LinkedHashMap.remove` calls, we can use value returned from single `allTaglets.remove` call.
> It's shorter and a bit faster.
> https://github.com/openjdk/jdk/blob/d46f404b3179c66e8e5775a9e2253c95238153c7/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java#L314-L325

Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into avoid_redundant_LinkedHashmap.get_in_TaglegManager
 - [PATCH] Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9137/files
  - new: https://git.openjdk.org/jdk/pull/9137/files/f24b0f7d..d27e4533

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9137&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9137&range=00-01

  Stats: 76858 lines in 1449 files changed: 45967 ins; 17240 del; 13651 mod
  Patch: https://git.openjdk.org/jdk/pull/9137.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9137/head:pull/9137

PR: https://git.openjdk.org/jdk/pull/9137


More information about the javadoc-dev mailing list