RFR: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag [v2]

[Jonathan Gibbons]

On Mon, 4 Jul 2022 15:09:50 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Instead of pair `LinkedHashMap.get`+`LinkedHashMap.remove` calls, we can use value returned from single `allTaglets.remove` call.
>> It's shorter and a bit faster.
>> https://github.com/openjdk/jdk/blob/d46f404b3179c66e8e5775a9e2253c95238153c7/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java#L314-L325
>
> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into avoid_redundant_LinkedHashmap.get_in_TaglegManager
>  - [PATCH] Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java line 314:

> 312:             return;
> 313:         }
> 314:         Taglet tag = allTaglets.remove(tagName);

The logic was somewhat clearer before. This code may be correct, but it would help to have an explanatory comment.
Note this code is only executed once per run of javadoc, so performance is definitely not an issue.

-------------

PR: https://git.openjdk.org/jdk/pull/9137