RFR: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag [v3]

Andrey Turbanov aturbanov at openjdk.org
Tue Jul 5 07:42:36 UTC 2022


> Instead of pair `LinkedHashMap.get`+`LinkedHashMap.remove` calls, we can use value returned from single `allTaglets.remove` call.
> It's shorter and a bit faster.
> https://github.com/openjdk/jdk/blob/d46f404b3179c66e8e5775a9e2253c95238153c7/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java#L314-L325

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag
  
  add suggested comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9137/files
  - new: https://git.openjdk.org/jdk/pull/9137/files/d27e4533..9c580c5a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9137&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9137&range=01-02

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/9137.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9137/head:pull/9137

PR: https://git.openjdk.org/jdk/pull/9137


More information about the javadoc-dev mailing list