RFR: 8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag [v3]

Attila Szegedi attila at openjdk.org
Sun Jul 10 13:33:52 UTC 2022


On Tue, 5 Jul 2022 07:42:36 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Instead of pair `LinkedHashMap.get`+`LinkedHashMap.remove` calls, we can use value returned from single `allTaglets.remove` call.
>> It's shorter and a bit faster.
>> https://github.com/openjdk/jdk/blob/d46f404b3179c66e8e5775a9e2253c95238153c7/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java#L314-L325
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8289658: Avoid redundant LinkedHashMap.get call in TagletManager.addNewSimpleCustomTag
>   
>   add suggested comment

Marked as reviewed by attila (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/9137


More information about the javadoc-dev mailing list