RFR: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx

[Jonathan Gibbons]

On Thu, 8 Sep 2022 09:46:20 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> @dumasun  reported the issue:
> 
> Configured with jfx-ls-modular-sdk:
> 
> 
> configure --with-import-modules=modular-sdk
> 
> 
> `make run-test CONF=fastdebug TEST="jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java"` failed:
> 
> 
> Starting subtest 1.7: checkOutput TEXT allowOverlaps:false expectFound:true expectOrdered:true
> FAILED: test/out/pkg/A.html: following text not found:
> <a href="#propProperty">prop</a>
> 
> 
> Thanks,
> Leslie Zhai

The edit to `JavadocTester` is inappropriate.

test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java line 836:

> 834:     public void checkOrder(String path, String... strings) {
> 835:         new OutputChecker(path)
> 836:                 .setExpectOrdered(false) // TODO, fix tests (6 failures) and change to true

This is not good, and affects any tests using this method.

It would be better to fix the test failures, or to modify the test to avoid calling this method. (i.e. move the TODO there, not here)

-------------

PR: https://git.openjdk.org/jdk/pull/10217